Dispatch environment_alg on OperatorStyle#397
Open
AFeuerpfeil wants to merge 3 commits intoQuantumKitHub:mainfrom
Open
Dispatch environment_alg on OperatorStyle#397AFeuerpfeil wants to merge 3 commits intoQuantumKitHub:mainfrom
environment_alg on OperatorStyle#397AFeuerpfeil wants to merge 3 commits intoQuantumKitHub:mainfrom
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Contributor
Author
|
@lkdvos As far as I can see this should be ready to merge. |
lkdvos
reviewed
Mar 21, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Is there a reason to include the geometrystyle here? I think this is only relevant for infinite systems, or are you thinking about having different infinite styles?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I now dispatch
environment_algonOperatorStyle(with a special case for quasi particles that we should discuss at some point in the future).