Skip to content

Remove explicit call to InfiniteMPS in VUMPS #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 12 commits into from
Mar 20, 2026
Merged

Remove explicit call to InfiniteMPS in VUMPS #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3a76f1b
remove explicit call to InfiniteMPS in VUMPS and IDMRG
AFeuerpfeil Feb 28, 2026
1829e5d
fix formatting
AFeuerpfeil Feb 28, 2026
ed3745c
revert original change and instead use gaugefix! in the gauging step
AFeuerpfeil Mar 2, 2026
5340c31
format
AFeuerpfeil Mar 2, 2026
3b44006
copy mps in VUMPSState to avoid modifying the input mps during the it…
AFeuerpfeil Mar 2, 2026
3f540b6
copy instead of similar in IDMRG
AFeuerpfeil Mar 2, 2026
b31c40f
fix vumps
AFeuerpfeil Mar 2, 2026
a5d05e1
Merge branch 'pr-styles-vumps' of github.com:AFeuerpfeil/MPSKit.jl in…
AFeuerpfeil Mar 2, 2026
4440785
hopefully fix idmrg bug (no copy needed, as mps is copied at the begi…
AFeuerpfeil Mar 2, 2026
1bfac78
hopefully fix idmrg
AFeuerpfeil Mar 3, 2026
cef9c0e
format
AFeuerpfeil Mar 4, 2026
548d2d5
small weird fixes
lkdvos Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/algorithms/groundstate/idmrg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function find_groundstate(mps, operator, alg::alg_type, envs = environments(mps,
end

alg_gauge = updatetol(alg.alg_gauge, it.state.iter, it.state.ϵ)
ψ′ = InfiniteMPS(it.state.mps.AR[1:end]; alg_gauge.tol, alg_gauge.maxiter)
ψ′ = InfiniteMPS(it.state.mps.AR; alg_gauge.tol, alg_gauge.maxiter)
envs = recalculate!(it.state.envs, ψ′, it.state.operator, ψ′)
return ψ′, envs, it.state.ϵ
end
Expand Down
10 changes: 8 additions & 2 deletions src/algorithms/groundstate/vumps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function dominant_eigsolve(
)
log = IterLog("VUMPS")
iter = 0
mps = copy(mps)
ϵ = calc_galerkin(mps, operator, mps, envs)
alg_environments = updatetol(alg.alg_environments, iter, ϵ)
recalculate!(envs, mps, operator, mps; alg_environments.tol)
Expand Down Expand Up @@ -110,7 +111,7 @@ function localupdate_step!(
mps = state.mps
src_Cs = mps isa Multiline ? eachcol(mps.C) : mps.C
src_ACs = mps isa Multiline ? eachcol(mps.AC) : mps.AC
ACs = similar(mps.AC)
ACs = mps.AL
dst_ACs = mps isa Multiline ? eachcol(ACs) : ACs

tforeach(eachsite(mps), src_ACs, src_Cs; scheduler) do site, AC₀, C₀
Expand Down Expand Up @@ -153,7 +154,12 @@ end

function gauge_step!(it::IterativeSolver{<:VUMPS}, state, ACs::AbstractVector)
alg_gauge = updatetol(it.alg_gauge, state.iter, state.ϵ)
return InfiniteMPS(ACs, state.mps.C[end]; alg_gauge.tol, alg_gauge.maxiter)
mps = gaugefix!(
state.mps, ACs, state.mps.C[end];
alg_gauge.tol, alg_gauge.maxiter, order = :R
)
mul!.(mps.AC, mps.AL, mps.C)
return mps
end
function gauge_step!(it::IterativeSolver{<:VUMPS}, state, ACs::AbstractMatrix)
alg_gauge = updatetol(it.alg_gauge, state.iter, state.ϵ)
Expand Down
Loading