Generalize calc_galerkin to AbstractMPS#395
Merged
lkdvos merged 9 commits intoQuantumKitHub:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
reviewed
Mar 2, 2026
lkdvos
force-pushed
the
pr-styles-galerkin
branch
from
b4bd9f3 to
a480a1c
Compare
lkdvos
approved these changes
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
… into pr-styles-galerkin
lkdvos
force-pushed
the
pr-styles-galerkin
branch
from
d26a4d7 to
a56c35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I unified the call to
calc_galerkinwithout supplying a position and then lifted the requirements ofUnion{InfiniteMPS, FiniteMPS, WindowMPS}toAbstractMPSby keeping the specialized function call for theMultilineMPS.