fix: Use pull_request_target in event name checks#3
Merged
Conversation
Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Claude
AI
changed the title
borchero
approved these changes
Mar 1, 2026
borchero
requested review from
EgeKaraismailogluQC and
MariusMerkleQC
as code owners
There was a problem hiding this comment.
Pull request overview
Updates the Chore GitHub Actions workflow so its conditional logic matches its pull_request_target trigger, preventing release drafting on PR events while still enabling PR checks/labeling.
Changes:
- Fixed job/step
if/ naming expressions to checkgithub.event_name == 'pull_request_target'instead of'pull_request'. - Ensured
release-drafterdisables release drafting on PR events viadisable-releaserwhile keeping auto-labeling enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
chore.ymlworkflow triggers onpull_request_targetbut was checkinggithub.event_name == 'pull_request', causing the release-drafter to draft releases on PRs instead of only assigning labels.Changes
'pull_request'to'pull_request_target'in:check-pr-titlejob condition (line 16) - now runs on PRsrelease-drafterjob name conditional (line 56)disable-releaserparameter (line 65) - critical fix preventing draft releases on PRsBehavior
On PRs: Checks title format, assigns labels, disables release drafting
On push to main: Drafts/updates releases, skips auto-labeling
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh pr view --json number,title,body /home/REDACTED/.nvm/bash_completion /home/REDACTED/.nvm/install.sh /home/REDACTED/.nvm/nvm-exec /home/REDACTED/.nvm/nvm.sh /home/REDACTED/.nvm/package.json /home/REDACTED/.nvm/rename_test.sh /home/REDACTED/.nvm/test(http block)If you need me to access, download, or install something from one of these locations, you can either: