Skip to content

update quantecon-book-theme to 0.20.1#847

Closed
mmcky wants to merge 2 commits intomainfrom
update/quantecon-book-theme-0.20.1
Closed

update quantecon-book-theme to 0.20.1#847
mmcky wants to merge 2 commits intomainfrom
update/quantecon-book-theme-0.20.1

Conversation

@mmcky
Copy link
Copy Markdown
Contributor

@mmcky mmcky commented Apr 6, 2026

Update quantecon-book-theme

This PR updates the theme to test the citation emphasis fix from QuantEcon/quantecon-book-theme#378.

What's being tested

The theme's emphasis styling (em elements display in teal color instead of italics) was incorrectly applied to "et al." text in sphinxcontrib-bibtex textual citations (:cite:t: with author_year style).

The fix adds a CSS :has() selector to match the HTML structure where <em>et al.</em> is a sibling of the <a class="reference"> link, not a child.

Preview pages to check

Next steps

Once the preview build confirms the fix works:

  1. Merge quantecon-book-theme#378
  2. Release quantecon-book-theme v0.20.2
  3. Update this PR to pin quantecon-book-theme==0.20.2
  4. Merge this PR

Copilot AI review requested due to automatic review settings April 6, 2026 01:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project build environment to use quantecon-book-theme v0.20.1 to pick up the latest theme fixes (notably citation link emphasis styling) and dependency compatibility improvements.

Changes:

  • Bump quantecon-book-theme from 0.19.0 to 0.20.1 in the conda/pip environment definition.

environment.yml Outdated
- pip:
- jupyter-book>=1.0.4post1,<2.0
- quantecon-book-theme==0.19.0
- quantecon-book-theme==0.20.1
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps quantecon-book-theme in environment.yml, but the scheduled .github/workflows/collab.yml workflow installs its own pinned quantecon-book-theme==0.8.2 (bypassing this environment). That means the Colab execution check won’t reflect the theme update and may render/test citations differently. Consider updating that workflow to use environment.yml (or at least bump the pinned theme version) so all builds validate the same dependency set.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

📖 Netlify Preview Ready!

Preview URL: https://pr-847--sunny-cactus-210e3e.netlify.app

Commit: 27e542b


Build Info

Install from QuantEcon/quantecon-book-theme@fix/citation-em-sibling-selector
to test the citation emphasis fix on the preview build.
@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Apr 6, 2026

Closing as tests are completed.

@mmcky mmcky closed this Apr 6, 2026
@mmcky mmcky deleted the update/quantecon-book-theme-0.20.1 branch April 6, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants