[CQT-59] implement SGMQ notation in the CircuitBuilder#675
Merged
rares1609 merged 3 commits intoApr 15, 2026
Conversation
elenbaasc
reviewed
Mar 30, 2026
Collaborator
elenbaasc
left a comment
elenbaasc
left a comment
There was a problem hiding this comment.
There are many helper functions that have been added to the CircuitBuilder, that are in my opinion overkill. For two qubit gates and the measure instruction we only allow for operand lists of equal lengths (and no tuple style SGMQ notation).
Try to simplify the (added) code significantly. Also, private helper functions shouldn't have doc-strings.
… and revise tests
elenbaasc
reviewed
Apr 14, 2026
Collaborator
elenbaasc
left a comment
elenbaasc
left a comment
There was a problem hiding this comment.
Great, thanks for cleaning it up! It's very close to being ready :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.