Skip to content

feat: generics for GraphQL subscriptions #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ndalpha merged 1 commit into from
Sep 19, 2025
Merged

feat: generics for GraphQL subscriptions #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/javascript-api/src/lib/services/graphql/graphql.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,11 @@ export class GraphqlService {
* }
* ```
*
* @param query required: the GraphQL query to send, for example `"subscription { createdTickets(locationId: 123) { id firstName } }"`
* @param queryDocument required: the GraphQL query to send, for example `"subscription { createdTickets(locationId: 123) { id firstName } }"`
* @returns an RxJS Observable that will push data as
* @throws when the 'query' argument is undefined or an empty string
*/
subscribe(queryDocument: QueryOrDocument): Observable<object> {
subscribe<T extends object>(queryDocument: QueryOrDocument): Observable<T> {
const query = queryToString(queryDocument);

if (!query || query.length === 0) {
Expand All @@ -198,7 +198,7 @@ export class GraphqlService {
);
}

return new Observable<object>((observer: Observer<object>) => {
return new Observable<T>((observer: Observer<T>) => {
const id = this.generateOperationId();
this.subscriptions.push(new Subscription(id, query));
this.sendMessage(id, MessageType.GQL_START, { query });
Expand Down
Loading