Skip to content

feat: extracting general errors from GraphQL responses #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ndalpha merged 3 commits into from
Sep 19, 2025
Merged

feat: extracting general errors from GraphQL responses #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e059f9
feat: extracting general errors from GraphQL responses
2ndalpha Sep 16, 2025
72d14b8
Fixed tests
2ndalpha Sep 16, 2025
b1a903d
Merge branch 'master' into siim/extract-error
2ndalpha Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/javascript-api/src/lib/services/api-base/api-base.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ describe('ApiBase', () => {
await Qminder.ApiBase.queryGraph(ME_ID.request);
}).rejects.toThrow(
new ResponseValidationError(
`Server response is not valid GraphQL response. Response: {}`,
'Error occurred! Could not extract error message!',
),
);
});
Expand Down
7 changes: 1 addition & 6 deletions packages/javascript-api/src/lib/services/api-base/api-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
isSuccessResponse,
} from '../../model/graphql-response.js';
import { RequestInit } from '../../model/fetch.js';
import { ResponseValidationError } from '../../model/errors/response-validation-error.js';

type RequestInitWithMethodRequired = Pick<RequestInit, 'method' | 'headers'> & {
body?: string | File | object;
Expand Down Expand Up @@ -151,11 +150,7 @@ export class ApiBase {
return graphQLResponse.data;
}

throw new ResponseValidationError(
`Server response is not valid GraphQL response. Response: ${JSON.stringify(
graphQLResponse,
)}`,
);
throw this.extractError(graphQLResponse);
}

private static extractError(response: any): Error {
Expand Down
Loading