Skip to content

feat: validating if ticket creation has expected response body #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2ndalpha merged 5 commits into from
Jan 3, 2025
Merged

feat: validating if ticket creation has expected response body #778

2ndalpha merged 5 commits into from
Jan 3, 2025

Conversation

@2ndalpha
Copy link
Member

@2ndalpha 2ndalpha commented Jan 3, 2025 •
edited
Loading

  • Testing if ticket creation response contains id
  • Refactored id to be always a string
  • Introduced new typed error ResponseValidationError
  • Bumped version to 14.0.0 because of the changed return type

@2ndalpha 2ndalpha requested a review from KarlMae January 3, 2025 10:16
@2ndalpha 2ndalpha marked this pull request as ready for review January 3, 2025 10:17
@2ndalpha 2ndalpha changed the title feat: validating if ticket creation succeeded feat: validating if ticket creation has expected response body Jan 3, 2025
KarlMae
KarlMae approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@KarlMae KarlMae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@2ndalpha 2ndalpha added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit d639f0b Jan 3, 2025
9 checks passed
@2ndalpha 2ndalpha deleted the siim/ticketcreationvalidation branch January 3, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KarlMae KarlMae KarlMae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2ndalpha @KarlMae