Skip to content

Conversation

@2ndalpha
Copy link
Member

@2ndalpha 2ndalpha commented Dec 16, 2024

  • Moved code to package/javascript-api
  • Had to lock mock-socket to version 9.2.1. For some reason Yarn resolved it to 9.3.0. Tests fail with newer versions.
  • Did split Github workflows
  • Removed some broken examples

Checklist

  • Code is covered with tests.

@2ndalpha 2ndalpha requested a review from KarlMae December 16, 2024 17:01
Copy link
Contributor

@KarlMae KarlMae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as expected, the build folder outputs seemed to match when building from master or from this branch.

We should do something about the cjs file eventually, though right now it was only moved.

@2ndalpha 2ndalpha added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit dff9394 Dec 17, 2024
8 checks passed
@2ndalpha 2ndalpha deleted the siim/restructure branch December 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants