Skip to content

fix: return temporary API key #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ndalpha merged 1 commit into from
Dec 16, 2024
Merged

fix: return temporary API key #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/services/temporary-api-key/temporary-api-key.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ describe('Temporary API Key Service', function () {
['{}', { status: 200 }],
[JSON.stringify({ key: '12345' }), { status: 200 }],
);
await service.fetchTemporaryApiKey();
let temporaryKey = await service.fetchTemporaryApiKey();
expect(temporaryKey).toEqual('12345');
});
});
8 changes: 2 additions & 6 deletions src/lib/services/temporary-api-key/temporary-api-key.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class TemporaryApiKeyService {
)}`,
);
}
return key;
} catch (e) {
console.error(
'[Qminder API]: Failed to parse the temporary API key response',
Expand All @@ -68,12 +69,7 @@ export class TemporaryApiKeyService {

private async retry(retryCount = 0): Promise<string> {
const timeOutMs = Math.min(60000, Math.max(5000, 2 ** retryCount * 1000));
const timeOutSec = timeOutMs / 1000;
console.info(
`[Qminder API]: Retrying to fetch API key in ${
timeOutSec / 1000
} seconds`,
);
console.info(`[Qminder API]: Retrying to fetch API key in ${timeOutMs} ms`);
await sleepMs(timeOutMs);
return this.fetchTemporaryApiKey(retryCount + 1);
}
Expand Down
Loading