Move pointwise_avg_3d into pointwise_avg #68
Open
chAwater wants to merge 4 commits intoQUVA-Lab:masterfrom
Open
Move pointwise_avg_3d into pointwise_avg #68chAwater wants to merge 4 commits intoQUVA-Lab:masterfrom
chAwater wants to merge 4 commits intoQUVA-Lab:masterfrom
Conversation
Signed-off-by: chenhe <chenhe@megarobo.tech>
Signed-off-by: chenhe <chenhe@megarobo.tech>
Signed-off-by: chenhe <chenhe@megarobo.tech>
Signed-off-by: chenhe <chenhe@megarobo.tech>
chAwater
commented
Jul 18, 2023
Comment on lines
265
to
+275
| filter_size = 2*int(round(3*sigma))+1 | ||
|
|
||
| self.kernel_size = (filter_size, filter_size) | ||
|
|
||
| if isinstance(stride, int): | ||
| self.stride = (stride, stride) | ||
| elif stride is None: | ||
| self.stride = self.kernel_size | ||
| else: | ||
| self.stride = stride | ||
|
|
||
| if stride is None: | ||
| stride = filter_size | ||
|
|
||
| if padding is None: | ||
| padding = int((filter_size-1)//2) | ||
|
|
||
| if isinstance(padding, int): | ||
| self.padding = (padding, padding) | ||
| else: | ||
| self.padding = padding | ||
|
|
||
| # Build the Gaussian smoothing filter | ||
| super(_PointwiseAvgPoolAntialiasedND, self).__init__( | ||
| in_type, d, filter_size, stride, padding | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I'm not familiar with the Antialiased part, especially the kernel_size you have mentioned in #36 (comment)
So I'm not sure this modification is compatible with your later plan for implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
exportfunction forPointwiseAvgPool, then I found the 3D and 2D are in separate files with similar codes, so I start to merge thempointwise_max.pypython -m unittest test/nn/test_pooling.pyandpython -m unittest test/nn/test_export.pyAntialiasedpart, so I labeled it with review commentContents
pointwise_avg_3d.pyintopointwise_avg.py- 388af7fexport(with tests) forPointwiseAvgPool2DandPointwiseAvgPool3D- 71967fa, 630de18ceil_modeinexportofPointwiseMaxPool2DandPointwiseMaxPool3D- 655a059