Keep Superpowers artifacts outside trusted plugin homes#128
Open
shaun0927 wants to merge 1 commit into
Open
Conversation
Dispatcher-based plugin invocation runs from the installed plugin home, so the Superpowers adapter must not default runtime artifacts into that immutable trust subject. Resolve output roots from explicit flags or dispatcher-provided environment first, then fall back to a user artifact area when running from the plugin tree. Constraint: Ouroboros firewall refuses subsequent invocations when plugin_home bytes drift after install. Rejected: Require users to always pass --output-dir | breaks manifest-facing dispatcher UX and still leaves future commands footgun-prone. Confidence: high Scope-risk: narrow Directive: Do not write runtime .omx artifacts into installed plugin homes; they are code trust subjects. Tested: python3 -m compileall -q plugins/superpowers/superpowers_ouroboros; python3 scripts/validate_contract.py; python3 -m unittest tests.test_superpowers_plugin tests.test_validator Not-tested: Full production dispatcher after the companion Ouroboros core PR lands
Collaborator
Author
|
Path-contract review note: A valid concern came up that
So non-OMX Ouroboros users on the dispatcher path get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Superpowers adapter for manifest-facing dispatcher invocation (
ouroboros superpowers ...) by keeping runtime artifacts out of the installed plugin home and accepting dispatcher-style--output-dirplacement.Problem
ouroboros superpowers test-driven-development ...launches the plugin entrypoint from the installed plugin home. Before this change, the adapter defaulted artifacts to./.omx/superpowers, which mutates the plugin install directory. Because plugin homes are trust subjects, later invocations can be blocked by digest drift.The dispatcher also passes user argv after the command name, so
ouroboros superpowers test-driven-development --output-dir <path>reaches the plugin as:The previous parser only accepted
--output-dirbefore the subcommand.Changes
--output-dirOUROBOROS_PLUGIN_OUTPUT_DIROUROBOROS_PLUGIN_WORKDIR/.omx/superpowers.omx/superpowers--output-dirbefore or after the subcommand.Validation
Also validated with the companion core branch that repeated dispatcher invocations work without trust-subject drift.