fix: decrease home data rate limits #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the rate limits for home data API calls to prevent instances from hitting Roborock's API rate limits and entering a degraded state. The change decreases the minute limit from 5 to 3 requests and the hourly limit from 15 to 5 requests.
Key Changes:
- Reduced home data API rate limit from 5 to 3 requests per minute
- Reduced home data API rate limit from 15 to 5 requests per hour
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15/hour seems to be too aggressive.
Something on my real instance got mad after the update and failed to get home data repeatedly. I wish I knew the cause, but unfortunately I do not as I did not have debug logging enabled, I just end up seeing the home data bucket full.
My instance ended up causing a slowdown on the app and I believe put itself in a bad state that maybe it continued to fail to get home data after sending ~15/hour for a few hours
Dramatically decreasing to limit potential rate limiting on Roborock's side and increase the chance of us automatically recovering.