Skip to content

Conversation

@allenporter
Copy link
Contributor

These are not used in any tests, but saved for future use. They are parsed as part of the mock data loading module to verify they are correct, but then not used.

Copilot AI review requested due to automatic review settings January 8, 2026 03:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test data files for the Roborock S5 Max (S5E model) device. The files contain product schema definitions and device state examples that will be parsed as part of the mock data loading module to verify correctness, though they are not currently used in active tests.

  • Adds product schema definition with 17 device capabilities/properties
  • Adds device state example with realistic status values

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/testdata/home_data_product_s5e.json Product schema definition for roborock.vacuum.s5e model with standard vacuum capabilities including RPC, error codes, state, battery, fan power, water box mode, brush/filter life indicators, and various task/status events
tests/testdata/home_data_device_s5e.json Device instance example for S5E with device metadata, Tuya integration details, and current device status values that reference the product schema IDs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenporter allenporter merged commit 586bb3f into Python-roborock:main Jan 8, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants