Add CartesianProductSet to PyROS#3927
Open
shermanjasonaf wants to merge 16 commits intoPyomo:mainfrom
Open
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
+ Coverage 89.98% 89.99% +0.01%
==========================================
Files 904 904
Lines 106891 106969 +78
==========================================
+ Hits 96191 96272 +81
+ Misses 10700 10697 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
approved these changes
May 6, 2026
Member
jsiirola
left a comment
There was a problem hiding this comment.
This looks good. Some minor updates to docstrings if you have time, but (in my opinion) nothing that must prevent merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR adds to PyROS the
CartesianProductSetclass, a new pre-implemented concreteUncertaintySetsubclass for representing a Cartesian product (or cross product) of uncertainty sets. For simplicity, this initial implementation of theCartesianProductSetdoes not support products involving one or more discrete uncertainty sets; such support will be added in a future PR.Changes proposed in this PR:
CartesianProductSetclassLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: