Skip to content

Conversation

@smondal13
Copy link
Contributor

Fixes # .

Summary/Motivation:

Pyomo.DoE documentation was old and needed an update.

Changes proposed in this PR:

  • Update the Pyomo.DoE documentation with the latest enhancements.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt
Copy link
Contributor

mrmundt commented Jan 9, 2026

@smondal13 - We have standardized to "Parmest" or "parmest", not "ParmEst". It's the source of the typo checker yelling at you.

@smondal13
Copy link
Contributor Author

Thank you @mrmundt

@smondal13
Copy link
Contributor Author

smondal13 commented Jan 9, 2026

@adowling2 @blnicho This PR is ready for review

Note: Merge PR #3803 before this one. The documentation in this PR contains updated information from that PR

:end-before: End sensitivity analysis

An example output of the code above, a design exploration for the initial concentration and temperature as experimental design variables with 9 values, produces the four figures summarized below:
.. code-block:: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you embedding the example instead of using .. literalinclude::? As implemented, this example is no longer being tested (which is a problem).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied and pasted the code from the example to skip the booleans that we have in the original example. However, I agree that testing this is important. So, I have added .. literalinclude:: and removed the copy-pasted code.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (168e961) to head (55af60a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
- Coverage   89.41%   89.41%   -0.01%     
==========================================
  Files         909      909              
  Lines      105579   105579              
==========================================
- Hits        94408    94407       -1     
- Misses      11171    11172       +1     
Flag Coverage Δ
builders 29.10% <ø> (-0.01%) ⬇️
default 86.04% <ø> (?)
expensive 35.76% <ø> (?)
linux 86.73% <ø> (-2.46%) ⬇️
linux_other 86.73% <ø> (-0.01%) ⬇️
osx 82.88% <ø> (ø)
win 84.98% <ø> (ø)
win_other 84.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blnicho blnicho self-requested a review January 13, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants