refactor(voice): Strict type checking in voice internals & DAVE Support (rec)

[Paillat-dev]

Summary

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.
• AI Usage has been disclosed.
  • If AI has been used, I understand fully what the code does

[pycord-app]

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3159/head:pr-3159
git checkout pr-3159

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3159/head

[Paillat-dev]

See if similar is required by other sinks or if it's even needed here idk if we might actually be better of undoing this. Test the other sinks

[Paillat-dev]

Is this breaking ?

[Paillat-dev]

changeling

[luc-rap]

Hi, I can't seem to get the recording properly stop and save the audio files. It just seems to be stuck somewhere never finishing the recording.

Logging in and connecting works. Recording starts, when typed !stop, Stopping recording for ... is outputed, but audio is not processed properly and seems to be hanging.

import discord
from dotenv import load_dotenv
import os
import json
import time
from discord.ext import commands
# import asyncio


load_dotenv()
RECORDINGS_DIR = "recordings"   
os.makedirs(RECORDINGS_DIR, exist_ok=True)

recording_start = {}
connections = {}

intents = discord.Intents.default()
intents.message_content = True
intents.voice_states = True

bot = commands.Bot(command_prefix="!", intents=intents)

async def finished_callback(sink: discord.sinks.WaveSink, ctx: commands.Context):
    """Called automatically when stop_recording() is called."""

    for user_id, audio in sink.audio_data.items():
        print(f"Processing audio for user {user_id} with attributes: {dir(audio)}")
        filename = f"{RECORDINGS_DIR}/{user_id}.wav"
        with open(filename, "wb") as f:
            f.write(audio.file.read())
        print(f"Saved {filename}")

    await ctx.send(f"Saved {len(sink.audio_data)} audio track(s).")

@bot.event
async def on_ready():
    print(f'We have logged in as {bot.user}')   
     
@bot.command()
async def record(ctx):
    if not ctx.author.voice:
        await ctx.send("You are not connected to a voice channel.")
        return
    
    if ctx.guild.voice_client:
        await ctx.guild.voice_client.disconnect()
        
    print(f"Connecting to {ctx.author.voice.channel}")
    vc = await ctx.author.voice.channel.connect()
    print(f"Is connected: {vc.is_connected()}")

    connections[ctx.guild.id] = (vc, sink := discord.sinks.WaveSink())
    recording_start[ctx.guild.id] = time.time()
    print(f"Connected: {vc}")
    vc.start_recording(
        sink,
        finished_callback
    )
    print("Recording started")
    await ctx.send("Recording started! Type `!stop` to stop.")
    
@bot.command()
async def stop(ctx: commands.Context):
    if ctx.guild.id not in connections:
        await ctx.send("Not recording.")
        return
    vc, sink = connections.pop(ctx.guild.id)
    print(f"Stopping recording for {vc}")
    vc.stop_recording()  
    await ctx.send("Stopping recording")
    
@bot.command()
async def check(ctx):
    if ctx.guild.id not in connections:
        await ctx.send("Not recording")
        return
    vc, sink = connections[ctx.guild.id]
    print(f"audio_data: {sink.audio_data}")
    print(f"is_recording: {vc.is_recording()}")
    await ctx.send(f"audio_data keys: {list(sink.audio_data.keys())}")
        
@bot.command()
async def disconnect(ctx: commands.Context):
    vc = ctx.guild.voice_client
    if vc:
        await vc.disconnect(force=True)
        await ctx.send("Disconnected.")
    else:
        await ctx.send("No voice client.")
        
bot.run(os.getenv('DISCORD_TOKEN'))

[brianmatzelle]

thank you for this change <3

can't wait for it to get in