fix: replace deprecated argument in ws_connect()#3105
Merged
Dorukyum merged 4 commits intoPycord-Development:masterfrom Feb 16, 2026
Merged
fix: replace deprecated argument in ws_connect()#3105Dorukyum merged 4 commits intoPycord-Development:masterfrom
Dorukyum merged 4 commits intoPycord-Development:masterfrom
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3105/head:pr-3105
git checkout pr-3105This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3105/head |
Dorukyum
reviewed
Feb 15, 2026
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Revnoplex <62947003+Revnoplex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Directly passing a float to the
timeoutparameter inaiohttp.ClientSession.ws_connect()has become deprecated and throws this warning:As the warning says
timeout=float_valueshould be replaced withtimeout=aiohttp.ClientWSTimeout(ws_close=float_value).Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.