Skip to content

fix: 🐛 Complete user update methods#3103

Draft
ToothyDev wants to merge 9 commits intoPycord-Development:masterfrom
ToothyDev:fix/complete-user-update-methods
Draft

fix: 🐛 Complete user update methods#3103
ToothyDev wants to merge 9 commits intoPycord-Development:masterfrom
ToothyDev:fix/complete-user-update-methods

Conversation

@ToothyDev
Copy link
Contributor

@ToothyDev ToothyDev commented Feb 14, 2026

Summary

Not all user object updates triggered the on_user_update_event, see the exact attributes which were missing in #3078
Also fixes an issue where User.nameplate is broken and inaccessible

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Closes #3078
Depends on #3107

@pycord-app
Copy link

pycord-app bot commented Feb 14, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3103/head:pr-3103
git checkout pr-3103

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3103/head

@Paillat-dev
Copy link
Member

image

@ToothyDev
Copy link
Contributor Author

ToothyDev commented Feb 14, 2026

I think I added all possible ones here for now. The missing ones are described in #3078 (comment) with a reason. accent_color might be doable as well but I wasn't sure because it would introduce potentially blocking // time-delaying code otherwise sync code.

Also, I tested all cases I could think of for now, but please do test as well in case I forgot about any

@ToothyDev ToothyDev mentioned this pull request Feb 14, 2026
9 tasks
CHANGELOG.md Outdated
Comment on lines 27 to 31
- Fixed updates of the following `User` attributes not triggering the `on_user_update`
event: `User.nameplate`.
([#3103](https://github.com/Pycord-Development/pycord/pull/3103))
- Fixed `User.nameplate` attribute not being accessible.
([#3103](https://github.com/Pycord-Development/pycord/pull/3103))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed updates of the following `User` attributes not triggering the `on_user_update`
event: `User.nameplate`.
([#3103](https://github.com/Pycord-Development/pycord/pull/3103))
- Fixed `User.nameplate` attribute not being accessible.
([#3103](https://github.com/Pycord-Development/pycord/pull/3103))
- Fixed `User.nameplate` not being accessible and its update not triggering the `user_update` event.
([#3103](https://github.com/Pycord-Development/pycord/pull/3103))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to include the avatar decoration data thing in the changelog so I left it at the old structure now, but updated

@ToothyDev
Copy link
Contributor Author

Currently paused / drafted as User.collectibles will be implemented before this

@Soheab Soheab added priority: medium Medium Priority status: in progress Work in Progess status: awaiting review Awaiting review from a maintainer API reflection Discord API isn't correctly reflected on hold labels Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API reflection Discord API isn't correctly reflected on hold priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer status: in progress Work in Progess

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Our user update method(s) might miss some parts

4 participants