Skip to content

fix: General fixes for views#3032

Merged
Paillat-dev merged 78 commits intoPycord-Development:masterfrom
NeloBlivion:cv2_fixes
Feb 7, 2026
Merged

fix: General fixes for views#3032
Paillat-dev merged 78 commits intoPycord-Development:masterfrom
NeloBlivion:cv2_fixes

Conversation

@NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Dec 23, 2025

Summary

Features previously in this PR have been moved to #3093

Non-urgent additions and adjustments to views, 2.7.1

  • underlying rework
  • ui.ActionRow.items (returns ActionRow.children)
  • ui.View.items (returns View.children)
  • ui.File.file
  • ui.Thumbnail.media
  • ui.MediaGallery.remove_item
  • move row to only button and select, deprecated on cv2 items
  • internal feature parity for modal items with view items
    • Modal.walk_children
    • support for modal items in _component_to_item
  • Docs fixes

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@pycord-app
Copy link

pycord-app bot commented Dec 23, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3032/head:pr-3032
git checkout pr-3032

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3032/head

@NeloBlivion NeloBlivion marked this pull request as ready for review December 24, 2025 06:16
@NeloBlivion NeloBlivion requested a review from a team as a code owner December 24, 2025 06:16
@NeloBlivion NeloBlivion added this to the v2.7 milestone Dec 24, 2025
@NeloBlivion
Copy link
Member Author

NeloBlivion commented Dec 24, 2025

from some testing by myself and luma this should fix the big issues in rc2, would appreciate if anyone could run a quick test on their own bot

@NeloBlivion NeloBlivion added this to the v2.7.1 milestone Feb 7, 2026
@NeloBlivion
Copy link
Member Author

updating later tonight; non-fixes in this PR will be removed

Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
@NeloBlivion NeloBlivion marked this pull request as ready for review February 7, 2026 23:35
Paillat-dev
Paillat-dev previously approved these changes Feb 7, 2026
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments; other than that code lgtm; tested in various situations & live bots and works fine; tysm !

Signed-off-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Paillat-dev Paillat-dev enabled auto-merge (squash) February 7, 2026 23:55
@Paillat-dev Paillat-dev disabled auto-merge February 7, 2026 23:57
@Paillat-dev Paillat-dev linked an issue Feb 7, 2026 that may be closed by this pull request
@Paillat-dev Paillat-dev merged commit a8d6e7b into Pycord-Development:master Feb 7, 2026
25 checks passed
Lulalaby added a commit that referenced this pull request Feb 9, 2026
* introduce replace_item and some additional patches

* style(pre-commit): auto fixes from pre-commit.com hooks

* cls

* style(pre-commit): auto fixes from pre-commit.com hooks

* rework underlying

* style(pre-commit): auto fixes from pre-commit.com hooks

* maybe fixed

* ,

* or

* spacing

* replace and remove on gallery

* style(pre-commit): auto fixes from pre-commit.com hooks

* index

* select_type

* row

* type

* cl

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix(actions): rework release workflow (#3034)

* fix(actions): rework release workflow

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-Authored-By: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

* style(pre-commit): auto fixes from pre-commit.com hooks

* revert cl

* files

* file again

* one more

* cl

* style(pre-commit): auto fixes from pre-commit.com hooks

* buildout for new features & items aliases

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix

* style(pre-commit): auto fixes from pre-commit.com hooks

* Iterator,

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix modal typing

* correct return types

* fix modal error docs

* remove incorrect release script

* fix paginator

* style(pre-commit): auto fixes from pre-commit.com hooks

* doc fix

* add convenience methods to DesignerView

* style(pre-commit): auto fixes from pre-commit.com hooks

* adjust underlying order

* fix fileupload

* misc

* view.add_row

* misc fixes

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix

* adjust legacy item attributes

* style(pre-commit): auto fixes from pre-commit.com hooks

* width docs adjustment

* style(pre-commit): auto fixes from pre-commit.com hooks

* remove new features for 3093

* style(pre-commit): auto fixes from pre-commit.com hooks

* change row to deprecation

* remove uncertain paginator fix

* file setter

* media setter

* dead changelog

* Update discord/ext/pages/pagination.py

Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>

* Update discord/ui/select.py

Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/ui/button.py

Signed-off-by: Paillat <jeremiecotti@ik.me>

---------

Signed-off-by: Lala Sabathil <lala@pycord.dev>
Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: Paillat <paillat@pycord.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Paillat <jeremiecotti@ik.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components Related to discord components (Views + Modals)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing for send_modal methods is incorrect View.remove_item and clear_items need their return types corrected and documented

6 participants