fix: GuildSchedule not being cached correctly + missing fields by Lumabots · Pull Request #3025 · Pycord-Development/pycord

Lumabots · 2025-12-09T19:51:26Z

Summary

summary is not complete, just check the code

Added
New Enums :
ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily)
ScheduledEventRecurrenceWeekday (monday-sunday)
ScheduledEventRecurrenceMonth (january-december)

New Classes:
ScheduledEventEntityMetadata (location)
ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday")
ScheduledEventRecurrenceRule: Full recurrence rule with validation

Auto-validates on to_payload() serialization
New fields Guild.create_scheduled_event():

well at this point just read the code

Enforces Discord's constraints:

Frequency-specific field combinations
Mutually exclusive field checks
Valid weekday set validation for daily events
Required field enforcement for yearly events

Information

This PR fixes an issue. on_scheduled_event_delete event parameter is useless #1709
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

…reason

…types

…from audit logs

…ation tests

pycord-app · 2025-12-09T19:51:30Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3025/head:pr-3025
git checkout pr-3025

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head

Lumabots · 2025-12-09T19:53:17Z

Audit Logs still need to be rework (i didnt understand how it work yet)

Lumabots · 2025-12-10T07:09:48Z

should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get
Open of better variable name

Paillat-dev

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

discord/enums.py

discord/scheduled_events.py

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-12-12T06:46:23Z

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

when anonymous pr will be merged i'll edit it to make it work

Lulalaby · 2025-12-12T08:29:18Z

fixed ur fux

…tributes

Lumabots · 2026-01-16T17:03:09Z

done, however i need help for the audit log, i dont understand anything and i tried...
i dont understand how it has been made and i dont think its working rn as its using location which doesnt exist
so yeah feel free to take a look or pr that

… performance

discord/scheduled_events.py

discord/iterators.py

discord/enums.py

discord/scheduled_events.py

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

…rameter in ScheduledEvent

Paillat-dev

Also for the changelog, make sure to mention all of the params renaming / deprecations and all that.

discord/guild.py

discord/state.py

…ectionState

… deprecate location parameter in ScheduledEvent

Paillat-dev · 2026-01-25T18:54:08Z

Will have to spend some time checking and working on the audit log stuff here

Lumabots · 2026-01-26T07:02:18Z

well spending some time yes and no, i was thinking after my exam to just make it work until next working all of that mess

Paillat-dev · 2026-02-13T12:58:39Z

Bump @Lumabots ?

Lumabots · 2026-02-13T18:30:52Z

Bump @Lumabots ?

Ill dive into that tomorrow

…t logs

Paillat-dev · 2026-02-15T16:14:29Z

discord/audit_logs.py



+def _transform_entity_metadata(
+    entry: AuditLogEntry, data: dict | str | None


Add generic typing to dict

Paillat-dev · 2026-02-15T16:15:54Z

discord/audit_logs.py

            _enum_transformer(enums.NotificationLevel),
        ),
+        "entity_metadata": (None, _transform_entity_metadata),
+        "location": (None, _transform_entity_metadata),


I feel like it is weird that they both get the same transformer when the two are different types

Lumabots added 6 commits December 9, 2025 15:49

at first i only wanted to add cached members...

43227c4

correcting some bs, like some unknow type added for i dont know what …

fe47678

…reason

use discord variable name, try an implementation for audit logs

fff9b3b

feat: add recurrence support for scheduled events with new enums and …

9e6a986

…types

refactor: remove ScheduledEventLocation class and related attributes …

7b2c31f

…from audit logs

feat: enhance scheduled event recurrence with validation and serializ…

5a2581e

…ation tests

Lumabots requested a review from a team as a code owner December 9, 2025 19:51

pullapprove4 bot requested a review from Lulalaby December 9, 2025 19:51

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Dec 9, 2025

Lumabots and others added 2 commits December 9, 2025 20:51

Merge branch 'master' into on_scheduled_event_delete

973a3d2

style(pre-commit): auto fixes from pre-commit.com hooks

9d1d5d7

Lumabots and others added 2 commits December 10, 2025 13:39

revert breaking change

8c85a05

style(pre-commit): auto fixes from pre-commit.com hooks

40d79b6

Paillat-dev changed the title ~~feat: Full rework of GuildSchedule~~ fux: GuildSchedule not being cached correctly Dec 10, 2025

Paillat-dev requested changes Dec 10, 2025

View reviewed changes

discord/enums.py Show resolved Hide resolved

discord/enums.py Outdated Show resolved Hide resolved

discord/scheduled_events.py Show resolved Hide resolved

discord/scheduled_events.py Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 10, 2025

Paillat-dev added API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing priority: medium Medium Priority labels Dec 10, 2025

Update discord/enums.py

b5dc3e9

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lulalaby changed the title ~~fux: GuildSchedule not being cached correctly~~ fix: GuildSchedule not being cached correctly Dec 12, 2025

refactor: 🗑️ Remove scheduled event recurrence classes and related at…

6dfd511

…tributes

Lumabots added 3 commits January 16, 2026 19:03

Update scheduled_events.py

7fdf52e

refactor: 🗑️ Change _cached_subscribers from dict to set for improved…

bafd549

… performance

paillat comment

8f887d3

Paillat-dev requested changes Jan 16, 2026

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Jan 16, 2026

Lumabots and others added 3 commits January 16, 2026 19:47

Update discord/enums.py

6772e09

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

refactor: 🗑️ Update location type references and deprecate 'cover' pa…

79194b5

…rameter in ScheduledEvent

style(pre-commit): auto fixes from pre-commit.com hooks

70c37cb

Paillat-dev requested changes Jan 16, 2026

View reviewed changes

discord/guild.py Show resolved Hide resolved

discord/guild.py Show resolved Hide resolved

discord/guild.py Show resolved Hide resolved

Paillat-dev reviewed Jan 16, 2026

View reviewed changes

discord/state.py Outdated Show resolved Hide resolved

Lumabots and others added 3 commits January 16, 2026 21:34

refactor: 🗑️ Remove unnecessary calls to _add_scheduled_event in Conn…

2800a08

…ectionState

refactor: 🗑️ Enhance create_scheduled_event method with overloads and…

b9ddb02

… deprecate location parameter in ScheduledEvent

style(pre-commit): auto fixes from pre-commit.com hooks

7b4f7f5

Paillat-dev self-assigned this Jan 25, 2026

Lumabots added 3 commits February 15, 2026 16:50

Merge branch 'master' into on_scheduled_event_delete

44fbd76

reverse

a548783

feat: Add entity metadata transformation for scheduled events in audi…

a594faa

…t logs

Lumabots requested a review from Paillat-dev February 15, 2026 16:07

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Feb 15, 2026

Paillat-dev reviewed Feb 15, 2026

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Feb 15, 2026



		def _transform_entity_metadata(
		entry: AuditLogEntry, data: dict \| str \| None

Uh oh!

Conversation

Lumabots commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app bot commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 10, 2025

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Dec 12, 2025

Uh oh!

Lulalaby commented Dec 12, 2025

Uh oh!

Lumabots commented Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paillat-dev commented Jan 25, 2026

Uh oh!

Lumabots commented Jan 26, 2026

Uh oh!

Paillat-dev commented Feb 13, 2026

Uh oh!

Lumabots commented Feb 13, 2026

Uh oh!

Paillat-dev Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Paillat-dev Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lumabots commented Dec 9, 2025 •

edited

Loading