Pypsa v1.1 compatibility and secant-based transmission losses#164
Merged
Pypsa v1.1 compatibility and secant-based transmission losses#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hotfix for pypsa 1.1.
overnight_costis now a reserved attribute of pypsa. The syntax is subtly different from how it is used here. That's why, for now, I just renamedovernight_costtoonight_cost. When pypsa-eur fully adopts the newovernight_cost,capital_cost,fom_costsyntax, we will deprecate onight_cost and follow pypsa-eur.Additionally, this PR switches to the new, secant-based transsmission loss approximation available in pypsa1.1.
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title