ci: include coverage from running build scripts#6007
Draft
davidhewitt wants to merge 7 commits intoPyO3:mainfrom
Draft
ci: include coverage from running build scripts#6007davidhewitt wants to merge 7 commits intoPyO3:mainfrom
davidhewitt wants to merge 7 commits intoPyO3:mainfrom
Conversation
Merging this PR will improve performance by 13.8%
Performance Changes
Comparing Footnotes
|
Contributor
|
Thanks for working on this! I noticed this looking at our clverage output for my build configuration PR. Happy to help out if you want a hand or an eye for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to improve coverage measurement of
pyo3-build-configby measuring the coverage of invocation ofbuild.rsfiles.I refactored a few common pieces about coverage measurement into helper actions so that I could re-use them from
test-version-limitsjob.