Open
Conversation
Tpt
force-pushed
the
tpt/allow-zero-sized-capsule
branch
from
1fc4d3a to
c5a29a9
Compare
Member
|
I think I'm in favour of this, seems like no technical reason we should restrict users in this way 👍 |
`Box::into_raw` never returns a null pointer so it seems safe
Tpt
force-pushed
the
tpt/allow-zero-sized-capsule
branch
from
c5a29a9 to
70c66a0
Compare
bschoenmaeckers
approved these changes
Mar 17, 2026
Member
|
Do we need to consider that the ZST story in C is at least somewhat convoluted? Or do we want to support this as a way of Rust to Rust communication over the C ABI? |
Contributor
Author
Good question. My "hot" take would be that if the user plans to dereference the pointer from C then they already need to care about the ABI of the pointed data, and care about ZST is part of it. So, preventing ZST is only a very small part of making this safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box::into_rawnever returns a null pointer so it seems safeAlternative to #5882, see this MR for context