Fix remote builds by making build-config contents deterministic #5745
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the usage of `env!`, we were baking paths to generated files in `lib.rs`. In setups where the build can be executed remotely (e.g. when building with Buck2), those paths would be different depending on whether the build ran locally or remotely. This difference propagates to `pyo3-macros`. Because Buck2 runs the metadata and codegen builds separately (for increased parallelism), they can have different contents due to the above, causing rustc to find two versions of the crate, and erroring out. This is not observable with Cargo because it runs both builds with the same rustc invocation. See facebook/buck2#1206 and rwf2/Rocket#2797 for more context. This commit fixes the issue by simply reading `OUT_DIR` at run-time, rather than compile-time, so that the content of `lib.rs` is fixed. Closes facebook/buck2#1206 Many thanks to https://github.com/cormacrelf for pointing out the root of the issue.
cbarrete
force-pushed
the
remote-build-fix
branch
from
f112e00 to
ac4ffa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for context.
Note that it I am not 100% confident about what impact this has on cross compilation, because there are no tests/examples for it.