Open
Conversation
…er init Extract parsing utilities (_extract_dict_path, _extract_xml_parameter) and refactor 5 methods to use them. Add state verification after Initialize. Remove redundant logs and simplify error handling.
- Enforce method vs protocol conventions
…sistency Split interface into send_command (result) and start_command (handle); rename backend get_method_by_name/list_method_names to get_method/list_methods; standardize docstrings and update README/notebook.
point, backend implements ThermocyclerBackend) instead of the original custom layout; improves consistency with PyLabRobot and gives a clear recommended API. - Rename odtc_xml → odtc_model; remove odtc.py; add ODTCThermocycler as preferred resource. Use computed estimated duration (PreMethod 10 min, Method from steps); stop parsing duration from device. - Backend/thermocycler interface updates; pass estimated duration through all execution paths. - README: Recommended Workflows (run by name, round-trip for thermal performance, set_block_temperature); clarify preserve temps when reusing ODTC config (only durations/cycle counts safe to change); trim redundancy.
…tures/waits. Docs+Formatting
…ess. Implement Get_Step,Cycle,Remaining methods. Cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ODTC backend. Runs on-device protocols, and uses a scratch protocol name for uploading and executing individual commands like set mount temperature.