feat(ui): add scroll-to-top FAB to the Schedule page#293
Closed
JacobCoffee wants to merge 1 commit intomainfrom
Closed
feat(ui): add scroll-to-top FAB to the Schedule page#293JacobCoffee wants to merge 1 commit intomainfrom
JacobCoffee wants to merge 1 commit intomainfrom
Conversation
PR #291 missed src/app/pages/schedule/ because its IonContent didn't have scrollEvents="true". Added the attribute, a #pageContent ref, the <app-scroll-to-top> component, and ScrollToTopModule on the schedule module. Coexists with the existing "Jump to Now" pill — FAB is bottom-end, "Jump to Now" is bottom-start. Depends on PR #291 (which introduces ScrollToTopModule). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
folded into #291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #291. Adds the same scroll-to-top FAB to the Schedule timeline tab — that page was skipped in #291 because its IonContent lacked scrollEvents=true.
Coexists with the existing 'Jump to Now' pill (FAB is bottom-end, pill is bottom-start).