fix(schedule): don't collapse same-named breaks across the day#289
Merged
JacobCoffee merged 1 commit intomainfrom May 1, 2026
Merged
fix(schedule): don't collapse same-named breaks across the day#289JacobCoffee merged 1 commit intomainfrom
JacobCoffee merged 1 commit intomainfrom
Conversation
The collapsedGroups key was \`kind-day-slotName\`, so Friday's 10:30 "Break" and 16:00 "Break" merged into one entry spanning 10:30-16:30 (earliest start, latest end across all matches). Same for any other days where multiple Break/Lunch/Poster slots share a name but sit at different times. Include the slot start in the key. Per-room same-start slots — the intended use case, e.g. five 13:00 "Lunch (Hall AB)" entries across talk rooms — still merge into one row. Cross-time slots no longer do. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Friday's morning Break (10:30-11:00) and afternoon Break (16:00-16:30) were collapsing into one row spanning 10:30-16:30 in the schedule and room views. Same key bug for any other day with multiple same-named Break / Lunch / Poster slots.
The collapsedGroups key was `kind-day-slotName`. Adding `-start` to the key keeps the intended use case (multiple per-room slots that share a start time merge into one row) while preventing cross-time collapsing.
Why it matters
Room 201B's Friday view shows "Break 10:30am-4:30pm" instead of two separate breaks at 10:30-11 and 16:00-16:30. The merged row also obscures the actual 10:30 morning break duration.
Test plan
🤖 Generated with Claude Code