Fix spurious nosec warning on f-strings with specific test IDs#1362
Open
worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
Open
Fix spurious nosec warning on f-strings with specific test IDs#1362worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
worksbyfriday wants to merge 2 commits intoPyCQA:mainfrom
Conversation
When a `# nosec B608` comment successfully suppressed an issue in an f-string, bandit emitted a spurious warning "nosec encountered (B608), but no failed test on line N" for the other Constant sub-nodes of the JoinedStr that intentionally returned no result. Track which (test_id, line) pairs have been suppressed and skip the warning when the same test was already suppressed on the same line range. Fixes PyCQA#1204 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# nosec B608successfully suppressed an issue in an f-string, bandit emitted a spurious warning:nosec encountered (B608), but no failed test on line NJoinedStrcontaining multipleConstantsub-nodes. B608 intentionally only checks the first sub-node (to avoid duplicate issues), but the "unused nosec" warning fired for the other sub-nodes that returned no result(test_id, line)pairs have been suppressed, and skipping the warning when the same test was already suppressed on lines in the same rangeFixes #1204
Test plan
f"SELECT * FROM {table}" # nosec B608— no spurious warningnosec B608on non-SQL string — warning still fires correctlyruff checkandruff formatpass