Migrate internal paths to use pathlib.Path instead of os.path (fixes #435)#444
Open
Krishnabhuvan wants to merge 6 commits intoPyAr:masterfrom
Open
Migrate internal paths to use pathlib.Path instead of os.path (fixes #435)#444Krishnabhuvan wants to merge 6 commits intoPyAr:masterfrom
Krishnabhuvan wants to merge 6 commits intoPyAr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435
This PR migrates all internal path handling from
os.pathstring-basedoperations to
pathlib.Pathobjects across the codebase.Changes made:
fades/helpers.py- replaced os.path.join, os.path.exists, expanduserfades/envbuilder.py- replaced os.path.join, os.path.split, os.path.existsfades/pipmanager.py- replaced os.path.join, os.path.existsfades/parsing.py- replaced os.path.join, os.path.dirnamefades/cache.py- replaced os.path.splitfades/main.py- replaced os.path.join, os.path.existsTests:
All 287 tests pass.