Exit after running export() #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 472046f.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the export() function to automatically exit after completion and provides a helpful command for copying exported weights to the environment's resources directory.
- Adds automatic exit after weight export completion
- Prints a copy command to help users move weights to the correct resources location
|
|
||
| target_name = env_name.replace('puffer_', '') | ||
| print(f'You can copy this to the environment\'s resources using cp -L {path} ./resources/{target_name}/{target_name}_weights.bin') | ||
| os._exit(0) |
There was a problem hiding this comment.
Using os._exit(0) bypasses normal cleanup and exception handling. Consider using sys.exit(0) instead, which allows for proper cleanup and exception handling.
Suggested change
| os._exit(0) | |
| sys.exit(0) |
This reverts commit 94cb725.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also print a command to copy the weights to the resources dir.