fix(libexpat): remove dead version target referencing missing versi…#6
Closed
rubnogueira wants to merge 1 commit into
Closed
fix(libexpat): remove dead version target referencing missing versi…#6rubnogueira wants to merge 1 commit into
version target referencing missing versi…#6rubnogueira wants to merge 1 commit into
Conversation
…on.c deps/libexpat/libexpat.gyp declared a top-level `version` executable target whose only source was `version.c` — a file that does not exist in the deps tree. Our binding only depends on the `:expat` static_library target, so on Linux/macOS `make` builds the dependency graph and silently skips the unused `version` target. MSBuild on Windows, however, builds every .vcxproj that gyp generates from the .gyp file. The vcxproj for the `version` target references a missing source file, and MSBuild bails out with exit code 2 before our actual binding ever gets a chance to compile. Removing the dead target unblocks the Windows build without affecting anything else (verified locally that darwin-arm64 still builds clean). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on.c
deps/libexpat/libexpat.gyp declared a top-level
versionexecutable target whose only source wasversion.c— a file that does not exist in the deps tree.Our binding only depends on the
:expatstatic_library target, so on Linux/macOSmakebuilds the dependency graph and silently skips the unusedversiontarget. MSBuild on Windows, however, builds every .vcxproj that gyp generates from the .gyp file. The vcxproj for theversiontarget references a missing source file, and MSBuild bails out with exit code 2 before our actual binding ever gets a chance to compile.Removing the dead target unblocks the Windows build without affecting anything else (verified locally that darwin-arm64 still builds clean).