ci: fix darwin-x64 + win32-x64 build, drop Node 20 action runtime#5
Merged
Conversation
- darwin-x64: cross-compile from a macos-14 (arm64) runner with --arch x64 instead of waiting on the capacity-starved macos-13 runner pool. Verified locally that the produced binary is "Mach-O 64-bit bundle x86_64". - win32-x64: drop the --strip flag on Windows. prebuild --strip spawns binutils' `strip` which is not on the Windows runner PATH; the spawn failure was what made every Windows build exit 2. Symbols stay in the .node binary (a few KB larger, functionally identical). - Bump actions/upload-artifact@v4 → v7 and actions/download-artifact@v4 → v8 so we stop pulling in the Node 20 action runtime. Both new majors share the same artifact storage backend and interoperate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stripwhich is not on the Windows runner PATH; the spawn failure was what made every Windows build exit 2. Symbols stay in the .node binary (a few KB larger, functionally identical).