test aleo types #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iamalwaysuncomfortable
left a comment
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
This is good so far, it simply needs more tests to cover the other types in the package.
| auction_id: true, | ||
| }; | ||
|
|
||
| const actualTxFromAPI: Transaction = |
There was a problem hiding this comment.
We probably want to move all of the test data to a separate file.
| import { Transaction } from "../src/transaction"; | ||
| import { parseValueToJson } from "../src/parsers/plaintext"; | ||
|
|
||
| const exampleAuctionRecord = { |
There was a problem hiding this comment.
We should get several example records and test them!
Member
iamalwaysuncomfortable
left a comment
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
We should get some tests surrounding:
- Being Able to Parse Entire Execution and Deployment Transactions with These types
- Handle parsing a variety plaintext Literal types and complex struct and arrays returned by mappings via parseValueToJSON
- Mappings
Also we should add a Block type.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Aleo types, validating that the defined types match real-world values. Adjust definitions accordingly.