fix: handle null Predis set members#204
Merged
Merged
Conversation
Signed-off-by: Simon Podlipsky <simon@podlipsky.net>
simPod
force-pushed
the
fix-predis-smembers-null
branch
from
83ba1bf to
a50d112
Compare
There was a problem hiding this comment.
Pull request overview
This PR makes the Predis Redis client wrapper more defensive by normalizing unexpected null responses from SMEMBERS to the adapter contract’s expected empty array behavior.
Changes:
- Coalesces
Predis\Client::smembers()null results to[]. - Adds a regression test covering null
SMEMBERSresponses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Prometheus/Storage/RedisClients/Predis.php |
Normalizes null smembers responses to an empty array. |
tests/Test/Prometheus/Storage/PredisTest.php |
Adds a unit regression test for null SMEMBERS results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It actually happened even though contract does not allow it.