Feature/isometries#314
Open
emanuel-malvetti wants to merge 34 commits intoProjectQ-Framework:developfrom
Open
Conversation
…lumn decomposition
…decompositions for the user qureg.
Takishima
requested changes
Jul 1, 2019
Collaborator
Takishima
left a comment
There was a problem hiding this comment.
Please fix the few issues I marked. Once that's done, I will go over this PR once again.
|
Emanuel Malvetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements decompositions for arbitrary isometries, diagonal gates and uniformly controlled single-qubit gates. (There is also code for uniformly controlled Rz rotations but it is not exposed in the interface.) Everything works well with controls, dagger and simulations except that isometries cannot be simulated. Everything is implemented both in C++ and Python.
A "master test" can be found in projectq/ops/_isometry_test.py
Relevant Papers:
Raban Iten, Roger Colbeck, Ivan Kukuljan, Jonathan Home, and Matthias Christandl. Quantum circuits for isometries. Phys. Rev. A, 93:032318, Mar 2016.
V. Bergholm M. Möttönen, J. J. Vartiainen and M. M. Salomaa. Quantum circuits with uniformly controlled one-qubit gates. Phys. Rev. A, 71:052330, 2005.
V. V. Shende, S. S. Bullock, and I. L. Markov. Synthesis of quantum-logic circuits. IEEE Transactions on Computer-Aided Design of Integrated Circuits and Systems, 25(6):1000–1010, 2006.