Merge from Upstream#128
Open
alanpoon wants to merge 1 commit intoProject-Robius-China:mainfrom
Open
Conversation
alanpoon
commented
Apr 29, 2026
alanpoon
commented
- ImageViewer - Open an image and check the auto-show/hide overlay behavior
- Context menu scroll blocking - Open a context menu (right-click on a message or room) and try scrolling
- App icons - Check the app icon appears correctly (visible in dock/taskbar)
Fixes an issue where the `formatted_caption()` for files, audio, and video messages was injected into the native HTML renderer (`show_html`) without explicitly verifying that the `format` type was `MessageFormat::Html`. This would allow a malicious actor to craft a payload with a non-HTML format type that contained malicious HTML tags, bypassing client-side sanitizers but executing in the UI. Now, the `format` is explicitly verified, falling back safely to plaintext via `htmlize::escape_text` if not explicitly declared as HTML. Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.