Skip to content

remove duplicate datasets from datasets.csv during aplose export #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gautzilla wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove duplicate datasets from datasets.csv during aplose export #246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df6dc38
remove duplicate datasets from datasets.csv during aplose export
Gautzilla Feb 13, 2025
ef5b5d8
add spectro_duration and dataset_sr in dataset filtering process
Gautzilla Feb 13, 2025
5402327
Merge branch 'main' into remove-duplicates-from-datasets-csv
Gautzilla Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/OSmOSE/utils/core_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,21 @@ def add_entry_for_APLOSE(path: str, file: str, info: pd.DataFrame):

if dataset_csv.exists():
meta = pd.read_csv(dataset_csv)
meta = pd.concat([meta, info], ignore_index=True).sort_values(
info.spectro_duration = info.spectro_duration.map(int)
info.dataset_sr = info.dataset_sr.map(int)
info.path = info.path.map(str)
meta = pd.concat(
(
meta[
(meta.path != str(info.iloc[0].path))
Copy link
Member

@ElodieENSTA ElodieENSTA Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the purpose here is not rather to handle multiple spectroduration X dataset_sr configuration for a same dataset (name AND path).

Copy link
Contributor Author

@Gautzilla Gautzilla Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's the point, but that's already what the changes do (unless I misunderstood your statement! 🥸):

pd.concat(
            (
                meta[  # Keeps any of the datasets that differs either in:
                    (meta.path != str(info.iloc[0].path)) # Path (includes name)
                    | (meta.spectro_duration != info.iloc[0].spectro_duration) # OR duration
                    | (meta.dataset_sr != info.iloc[0].dataset_sr) # OR sample rate
                ],
                info, # Adds the current dataset
            )
)

This way, if one creates a new dataset that only differs in sample rate, it will be added in addition to the previous dataset since (meta.dataset_sr != info.iloc[0].dataset_sr) will return True.

| (meta.spectro_duration != info.iloc[0].spectro_duration)
| (meta.dataset_sr != info.iloc[0].dataset_sr)
],
info,
),
ignore_index=True,
)
meta = meta.sort_values(
by=["path", "dataset"],
ascending=True,
)
Expand Down