Skip to content

chore(ci): build on windows-2025-vs2026#7550

Open
DennisOSRM wants to merge 2 commits into
masterfrom
DennisOSRM-patch-1
Open

chore(ci): build on windows-2025-vs2026#7550
DennisOSRM wants to merge 2 commits into
masterfrom
DennisOSRM-patch-1

Conversation

@DennisOSRM
Copy link
Copy Markdown
Collaborator

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.

Was this change primarily generated using an AI tool?
Kindly make this transparent and disclose which tool / model you have been using.
Please note our contribution guidlines on the use of AI tools.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Copilot AI review requested due to automatic review settings May 12, 2026 21:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflow to run the Windows vcpkg release/bindings job on a different Windows runner image label, presumably to validate builds against a newer Visual Studio toolchain.

Changes:

  • Switch the Windows CI job runner from windows-2025 to windows-2025-vs2026 for vcpkg-windows-release-bindings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DennisOSRM DennisOSRM changed the title chore: try build on windows-2025-vs2026 chore(ci): build on windows-2025-vs2026 May 13, 2026
@nilsnolde
Copy link
Copy Markdown
Contributor

cool, it worked! so nothing has to be done, we can just wait it out.

fwiw, python bindings on windows are not sensitive to msvc changes I think, at least it bundles msvcp140.dll. too lazy to ask claude, counting on the collective intelligence instead:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants