Skip to content

fix(car): refactor access tag analysis #7539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DennisOSRM wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(car): refactor access tag analysis #7539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a403a2
fix(car): refactor access tag analysis
DennisOSRM May 7, 2026
8213387
fix: trim whitespace in resolve_access and use official (singular)
DennisOSRM May 7, 2026
e1e6f81
fix: use separate local for trimmed part in resolve_access
DennisOSRM May 7, 2026
b2df2b0
Merge branch 'master' into refactor_access_analysis
DennisOSRM May 9, 2026
cb35f66
Merge branch 'master' into refactor_access_analysis
DennisOSRM May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 78 additions & 9 deletions features/car/access.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ Feature: Car - Restricted access
| delivery | x |
| some_tag | x |
| destination | x |
| permit | x |
| residents | x |
| foot | |
| restricted | |
| military | |
| official | |
| emergency_vehicle | |
| unknown | x |
Comment on lines +133 to +140
| agricultural;forestry | |


Scenario: Car - Access tags on nodes
Expand All @@ -149,6 +158,39 @@ Feature: Car - Restricted access
| bus | |
| delivery | x |
| some_tag | x |
| permit | x |
| residents | x |
| foot | |
| restricted | |
| military | |
| official | |
| emergency_vehicle | |
| unknown | x |
| agricultural;forestry | |

Scenario: Car - Motorcar access tags on ways
Then routability should be
| motorcar | bothw |
| yes | x |
| permissive | x |
| designated | x |
| no | |
| private | x |
| agricultural | |
| forestry | |
| psv | |
| delivery | x |
| destination | x |
| permit | x |
| customers | x |
| residents | x |
| foot | |
| restricted | |
| military | |
| official | |
| emergency_vehicle | |
| unknown | x |
| agricultural;forestry | |

Scenario: Car - Access tags on both node and way
Then routability should be
Expand Down Expand Up @@ -275,7 +317,25 @@ Feature: Car - Restricted access
| primary | | no | destination | | x | |
| primary | destination;agricultural | destination | | x | x | |
| footway | | | destination | | | temporary #3373 |
| track | destination;agricultural | destination | | | x | temporary #3373 |
| track | destination;agricultural | destination | | | | temporary #3373 |

Scenario: Car - Semicolon-separated access tags are split and resolved individually
Then routability should be
| highway | access | motorcar | bothw | # |
| primary | agricultural;forestry | | | access: both blacklisted |
| primary | destination;agricultural | | x | access: restricted wins over blacklisted |
| primary | yes;agricultural | | x | access: whitelisted wins over blacklisted |
| primary | yes;no | | x | access: whitelisted wins over blacklisted |
| primary | permissive;forestry | | x | access: whitelisted wins over blacklisted |
| primary | destination;delivery | | x | access: both restricted |
| primary | | agricultural;forestry | | motorcar: both blacklisted |
| primary | | destination;agricultural | x | motorcar: restricted wins over blacklisted |
| primary | | yes;agricultural | x | motorcar: whitelisted wins over blacklisted |
| primary | | yes;no | x | motorcar: whitelisted wins over blacklisted |
| primary | | permissive;forestry | x | motorcar: whitelisted wins over blacklisted |
| primary | | destination;delivery | x | motorcar: both restricted |
| primary | forestry;permissive | | x | access: whitelisted wins over blacklisted |
| primary | | forestry;permissive | x | motorcar: whitelisted wins over blacklisted |

Scenario: Car - Don't route over steps even if marked as accessible
Then routability should be
Expand Down Expand Up @@ -305,14 +365,21 @@ Feature: Car - Restricted access

Scenario: Car - Access blacklist
Then routability should be
| highway | access | bothw |
| primary | | x |
| primary | emergency | |
| primary | forestry | |
| primary | agricultural | |
| primary | psv | |
| primary | no | |
| primary | customers | x |
| highway | access | bothw |
| primary | | x |
| primary | emergency | |
| primary | forestry | |
| primary | agricultural | |
| primary | agricultural;forestry| |
| primary | psv | |
| primary | no | |
| primary | foot | |
| primary | restricted | |
| primary | military | |
| primary | official | |
| primary | customers | x |
| primary | permit | x |
| primary | residents | x |

Scenario: Car - Winter/ice roads with restricted access
Then routability should be
Expand All @@ -322,10 +389,12 @@ Feature: Car - Restricted access
| winter_road| private | x |
| winter_road| delivery | x |
| winter_road| destination | x |
| winter_road| permit | x |
| winter_road| no | |
| ice_road | | x |
| ice_road | yes | x |
| ice_road | private | x |
| ice_road | delivery | x |
| ice_road | destination | x |
| ice_road | permit | x |
| ice_road | no | |
17 changes: 14 additions & 3 deletions profiles/car.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Handlers = require("lib/way_handlers")
Relations = require("lib/relations")
Obstacles = require("lib/obstacles")
find_access_tag = require("lib/access").find_access_tag
resolve_access = require("lib/access").resolve_access
limit = require("lib/maxspeed").limit
Utils = require("lib/utils")
Measure = require("lib/measure")
Expand Down Expand Up @@ -85,7 +86,8 @@ function setup()
'vehicle',
'permissive',
'designated',
'hov'
'hov',
'unknown'
},

access_tag_blacklist = Set {
Expand All @@ -98,10 +100,17 @@ function setup()
'share_taxi', -- sub class of psv
'minibus', -- sub class of psv
'bus', -- sub class of psv
'foot',
'emergency_vehicle',
'restricted',
'military',
'official',
'customers',
'private',
'delivery',
'destination'
'destination',
'permit',
'residents'
},

-- tags disallow access to in combination with highway=service
Expand All @@ -114,6 +123,8 @@ function setup()
'delivery',
'destination',
'customers',
'permit',
'residents',
},

access_tags_hierarchy = Sequence {
Expand Down Expand Up @@ -362,7 +373,7 @@ end

function process_node(profile, node, result, relations)
-- parse access and barrier tags
local access = find_access_tag(node, profile.access_tags_hierarchy)
local access = resolve_access(find_access_tag(node, profile.access_tags_hierarchy), profile)
if access then
if profile.access_tag_blacklist[access] and not profile.restricted_access_tag_list[access] then
obstacle_map:add(node, Obstacle.new(obstacle_type.barrier))
Expand Down
26 changes: 26 additions & 0 deletions profiles/lib/access.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,30 @@ function Access.find_access_tag(source,access_tags_hierarchy)
return nil
end

function Access.classify_access(value, profile)
if profile.access_tag_whitelist[value] then return 3 end
if profile.restricted_access_tag_list[value] then return 2 end
if profile.access_tag_blacklist[value] then return 1 end
return 0
end

function Access.resolve_access(value, profile)
if not value then return nil end
if not value:find(';') then return value end

local best = nil
local best_priority = -1

for part in value:gmatch('[^;]+') do
local trimmed = part:match('^%s*(.-)%s*$')
local priority = Access.classify_access(trimmed, profile)
if priority > best_priority then
best = trimmed
best_priority = priority
end
end

return best or value
end

return Access
4 changes: 4 additions & 0 deletions profiles/lib/way_handlers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ local set_classification = require("lib/guidance").set_classification
local get_destination = require("lib/destination").get_destination
local Tags = require('lib/tags')
local Measure = require("lib/measure")
local resolve_access = require("lib/access").resolve_access

WayHandlers = {}

Expand Down Expand Up @@ -260,6 +261,9 @@ function WayHandlers.access(profile,way,result,data)
data.forward_access, data.backward_access =
Tags.get_forward_backward_by_set(way,data,profile.access_tags_hierarchy)

data.forward_access = resolve_access(data.forward_access, profile)
data.backward_access = resolve_access(data.backward_access, profile)

-- only allow a subset of roads to be treated as restricted
if profile.restricted_highway_whitelist[data.highway] then
if profile.restricted_access_tag_list[data.forward_access] then
Expand Down
6 changes: 6 additions & 0 deletions taginfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@
{"key": "access", "value": "minibus"},
{"key": "access", "value": "bus"},
{"key": "access", "value": "delivery"},
{"key": "access", "value": "permit"},
{"key": "access", "value": "residents"},
{"key": "access", "value": "foot"},
{"key": "access", "value": "restricted"},
{"key": "access", "value": "military"},
{"key": "access", "value": "official"},
{"key": "maxheight", "object_types": ["node", "way"]},
{"key": "maxspeed", "value": "none"},
{"key": "maxspeed", "value": "urban"},
Expand Down
Loading