fix: implement comparison operator for vector view#7538
Merged
Conversation
The iterator was missing ordering operators. C++20 ranges concepts checks require these for random access iterator. Fixes compilation of #7444.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make util::VectorViewIterator satisfy C++20 random access iterator requirements by adding ordering comparisons (needed for C++20 ranges concept checks), addressing the compilation failure referenced in #7444.
Changes:
- Add
<compare>include to support three-way comparison. - Replace hand-written equality/inequality operators with defaulted
operator==. - Introduce a defaulted three-way comparison operator (
operator<=>) for iterator ordering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterator was missing ordering operators. C++20 ranges concepts checks require these for random access iterator. Fixes compilation of #7444.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.
Was this change primarily generated using an AI tool?
Kindly make this transparent and disclose which tool / model you have been using.
Please note our contribution guidlines on the use of AI tools.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?