Add --list-inputs option to all OSRM tools for deployment scripts#7350
Open
afarber wants to merge 6 commits intoProject-OSRM:masterfrom
Open
Add --list-inputs option to all OSRM tools for deployment scripts#7350afarber wants to merge 6 commits intoProject-OSRM:masterfrom
afarber wants to merge 6 commits intoProject-OSRM:masterfrom
Conversation
b023140 to
add48af
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --list-inputs command-line option to all OSRM tools (osrm-routed, osrm-datastore, osrm-partition, osrm-extract, osrm-customize, osrm-contract) to help deployment scripts identify which input files are required and optional for each tool. This addresses issue #2865 by providing a programmatic way to determine file dependencies without hardcoding them in deployment scripts.
Changes:
- Added
ListInputFiles()method toIOConfigclass that outputs required and optional input file extensions - Integrated
--list-inputsoption into all six OSRM command-line tools - Added comprehensive unit tests for the new functionality
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| include/storage/io_config.hpp | Adds ListInputFiles method to IOConfig base class to output required/optional file extensions |
| unit_tests/storage/io_config.cpp | Comprehensive unit tests for ListInputFiles covering various scenarios including empty strings and edge cases |
| src/tools/routed.cpp | Adds --list-inputs option to osrm-routed command-line interface |
| src/tools/store.cpp | Adds --list-inputs option to osrm-datastore command-line interface |
| src/tools/partition.cpp | Adds --list-inputs option to osrm-partition command-line interface |
| src/tools/extract.cpp | Adds --list-inputs option to osrm-extract command-line interface |
| src/tools/customize.cpp | Adds --list-inputs option to osrm-customize, lists both main config and updater config files |
| src/tools/contract.cpp | Adds --list-inputs option to osrm-contract, lists both main config and updater config files |
| docs/routed.md | Documents the new --list-inputs option with usage examples |
| CHANGELOG.md | Adds entry for the new feature under Misc section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
87db89e to
96a6116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2865
This PR adds a
--list-inputsoption to all OSRM tools that outputs the required and optional input file extensions. This helps deployment scripts know which files need to be copied for each tool.Example usage:
Tasklist
Requirements / Relations
#3920