#7047: Nearest api returning node with id 0

[muteebali]

Issue

Bug: Nearest api returning node with id 0

Tasklist

• Change the nearest_api.hpp code
• Update ChangeLog.md

Snapshot of bug fix

FYI @jcoupey

[github-actions]

This PR seems to be stale. Is it still relevant?

[moboge]

@jcoupey any idea on when this PR can be merged into the master?

[DennisOSRM]

i have this on my plate for the coming week.

[DennisOSRM]

Change looks good to me. What we'd need is a test case that fails without this change and succeeds with it.

[afarber]

Wouldn't this be more readable?

else if (phantom_node.forward_segment_id.enabled && phantom_node.fwd_segment_position == 0)
{
    // At the very beginning of a one-way forward geometry.
    // Segment runs from the first OSM node to the second OSM node.
    // We require at least 2 nodes in forward_geometry to form a valid edge.
    BOOST_ASSERT(forward_geometry.size() >= 2);

    auto from_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[0]);
    auto to_osm_node   = facade.GetOSMNodeIDOfNode(forward_geometry[1]);

    from_node = static_cast<std::uint64_t>(from_osm_node);
    to_node   = static_cast<std::uint64_t>(to_osm_node);
}