Note effects #50
Merged
Note effects #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two notes will be displayed to the player, the one in the circle will be the next note that will be placed. currently supports "single" and "double" notes, where double notes are supposed to eventually give double points.
SaveData.json can store all our game's save data (unless we want to split the save data amongst different files). NoteQueue now pulls notes from the SaveData.
NoteArrow has been given a variable of type Note to represent what special note is held in there. Notes created by the chart or enemy are assigned the type enemy, while notes placed by the player are assigned based on the noteQueue. Also, the queue doesn't "loop" so when the player runs out, they can no longer place notes.
LifeHckr
approved these changes
Feb 13, 2025
Contributor
LifeHckr
left a comment
LifeHckr
left a comment
There was a problem hiding this comment.
Gonna integrate. We can keep the save system for later, but note queue shouldn't need to read the save file during run time.
Contributor
There was a problem hiding this comment.
Some of this was on me, the point of noteIdx was to just keep the note index instead of a note ref, so notes could stay the same, but depending on how effects could work, it will probably make more sense to hold a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't automerge because of changes to test_battle_scene.tcsn
Tested it with the test_battle_scene.tcsn file from note-effects branch and seems to work fine.
Currently the noteQueue doesn't support "looping/repeating" the queue after the user runs through all available notes, can add later if wanted.
Also check out files "SaveData.json" and "SaveSystem.cs" for possible save feature, at the moment the JSON is what gives the player their special notes.