Merge Final Sprint 1 Playable into Main! #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes spawn and move, but don't yet support anything else. Also, the structure in NoteManager needs some work
Add initial Note system
Prototyping spacing and looping for chart.
Needs to be integrated with other systems Needs intended visuals Logic has all been ironed out. (In theory)
Restructured file organization Consolidated visual information to ChartManager Reworked Note into NoteArrow to represent chart indications Skeleton classes for eventual objects
S1 chart looping Merge into Sprint-1 working branch
Very hacky, but it works now.
Created a ProgressBar and a script that will update the values of the progress bar and a damage function that should reduce health. For debugging purposes,pressing spacebar will call damage.
made a tscn and changed position
Made a very basic player and enemy place holder objects and scripts. BattleManager has two signals, it will send them based on score to either player or enemy. Player and enemy have a healthBar and a ref to the BattleManagerInstance. Could be cleaner with where the actual health variable is stored.
Moved timing to a global timer using the TimeKeeper singleton. This dramatically improved mistiming, and synced everything that cares to be synced. Added event bubbling for input. Reworked ArrowType enum to have strict int values for simplicity. Simplified dictionaries representing lane based data into arrays Simplified notearrows to sprite2d and shifted test_scene for easy visual syncing.
Enforced signal up call down. Removed signals from BattleDirector to HP bars.
Enemy and Player consolidated to HealthBar
General reorganization and code cleanup
Input timing and HP bars finished
notes that have been added by the player only appear when they are about 1/3rd of the way through the track
Might have been an issue on my end: ChartManager got disconnected from NoteManager
Player adding notes
Renamed node manager for clarity Streamlined and consolidated adding notes into _laneData, to guarantee synced queues. NoteArrows hold noteIdx for eventual roguelike elements
Notes no longer loop with increased beat
Adding character sprites Textured bars Animated notes
Don't let the rewritten history fool you, NotePlacementBar was just integrated now. I need sleep.
Made added notes tween to the same rhythm Fixed issues when adding notes being considered active at wrong times
Reworked note management (again) Set size 2D arrays for notes, that slot in their beat position. Queue-like checking for missed notes Added in game feedback for hit timing quality
Added audio Made small fixes, no more beat 0 Created first chart
Finalized sprint 1 version
collectioncard
requested changes
Feb 4, 2025
Member
collectioncard
left a comment
collectioncard
left a comment
There was a problem hiding this comment.
Need to do the things in my comments before we merge
Also added song attribution to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone complete Pog