-
Notifications
You must be signed in to change notification settings - Fork 0
Added Enemy notes #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Enemy notes #195
Conversation
This never needs to be in the constructor Added SetOwner function
Player notes now are sorted correctly Scaffolding AddConcurrentNote
Consider this change experimental, not 100% sure the SpawnNotesAtBeat loop works exactly as intended.
Temperamental conditions Notes in the first visible parts of the chart have to be added on battle start, with a 1 loop offset Otherwise, they HAVE to be added OnLoop, with beatPos set and loop 0 They cannot overwrite player notes, will throw a completely safe warning
Any puppet can apply note types to base notes Limitations: Notes are only applied to notes that had EnemyBase. Notes can only be applied randomly.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This also allows for new player effects to place or overwrite notes.