Custom remapping

[cornerloan]

Current issues:

• UI on buttons cannot be moved left to right using WASD or controller.
• Currently set to change your input type based on what tab you left open when you exit this menu, could change this to a button or dropdown.
• Can always use appearance improvements.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[collectioncard]

@coderabbitai review

IDK why, I think the rabbit is funny

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get basic PR information
gh pr view 159 --json title,body,state,baseRefName,headRefName,url

# Get information about changed files
gh pr view 159 --json files --jq '.files[] | {path: .path, additions: .additions, deletions: .deletions}'

# Check for CodeRabbit configuration
if [ -f .coderabbit.yaml ]; then
  cat .coderabbit.yaml
else
  echo "No .coderabbit.yaml configuration file found"
fi

# Check default branch information
gh repo view Project-Funk-Engine/ProjectFunkEngine --json defaultBranchRef

Length of output: 9061

---

🏁 Script executed:

#!/bin/bash
# Let's examine the main code changes to understand the PR
cat Globals/SaveSystem.cs

Length of output: 16822

---

🏁 Script executed:

#!/bin/bash
# Let's check the InputHandler.cs to understand those changes
cat Scenes/NoteManager/Scripts/InputHandler.cs

# Also check the NotePlacementBar.cs
cat Scenes/BattleDirector/Scripts/NotePlacementBar.cs

# Let's also look at the translations changes
cat Globals/Translations/Translations.csv

# Let's try to find the remapping UI scene
fd -t f "Remapping.tscn" .

Length of output: 14854

---

@collectioncard I've reviewed your PR that adds custom input remapping functionality. Great work! Here's my review:

Overall

The implementation of custom key remapping looks solid. You've created a flexible system that handles both keyboard and controller inputs, with proper configuration saving and loading.

Strengths

• Well-structured code for managing input bindings
• Good separation of keyboard and controller input handling
• Clean integration with the existing save system
• Complete set of key/button assets for the UI

Observations

• The ApplySavedInputBindings() method clears and re-adds all action events, which is an efficient approach
• Good error handling when parsing joypad buttons
• The UI updates included a significant number of assets for keyboard keys and controller buttons

Suggestions

1. For the issue with UI buttons not responding to WASD/controller, consider using Godot's focus system to allow navigation between UI elements
2. For the input type selection, you might want to add a dedicated dropdown or radio button selection rather than relying on the last selected tab
3. Consider adding a preview/test area where users can immediately try their new bindings

The PR adds a nice quality-of-life feature that will make the game more accessible to players with different preferences or needs. I'm impressed with how neatly you've integrated this into the existing codebase.

[collectioncard]

I think it looks good, but I cant move to all of the buttons with wasd or arrow keys. Didnt try controller.