4.4 migration and Fix Folder Names #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some UI change focus behavior, since 4.4 seemed to break/change it.
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces new unique identifiers (UIDs) for many modules across the project. Changes are applied to files in classes, globals, scenes, and shared assets, ensuring each component is uniquely trackable. The project file is updated to use a newer Godot.NET SDK version and a unified target framework. Additionally, UI components have been enhanced by adding focus navigation properties and updating node names, and minor configuration changes have been made in the project settings. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User Input
participant I as Inventory
participant N as _notes Container
participant R as _relics Container
U->>I: Trigger _Input event (tab selection)
alt Tab 0 selected
I->>N: Check for child nodes
alt Child exists
N-->>I: Return first child's node path
I->>I: Set FocusNeighborBottom to node path
else
I->>I: Set FocusNeighborBottom to null
end
else Tab 1 selected
I->>R: Check for child nodes
alt Child exists
R-->>I: Return first child's node path
I->>I: Set FocusNeighborBottom to node path
else
I->>I: Set FocusNeighborBottom to null
end
end
sequenceDiagram
participant U as User
participant W as WASDButton
participant C as ControllerButton
U->>W: Navigate focus (Left/Right)
W->>C: Transfer focus via focus_neighbor_left property
C->>W: Transfer focus via focus_neighbor_right property
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (59)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores