문화축제 API 호출입니다. #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingu9
reviewed
Oct 10, 2023
| CatcherJsonParser festivalParser = new CatcherJsonParser(headerPath, bodyPath) { | ||
| @Override | ||
| public String getUri(int page, int count) { | ||
| return new StringBuilder() |
Contributor
There was a problem hiding this comment.
요부분은 실제로 사용하실때는 UriBuilder를 이용하여 만들면 더 좋을거같습니다~
pingu9
approved these changes
Oct 10, 2023
Contributor
pingu9
left a comment
pingu9
left a comment
There was a problem hiding this comment.
코멘트 하나 남겼던 부분 말고는 좋아보입니다! 고생많으셨습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
축제명, 축제기간, 축제장소를 파싱하여 우리 캐쳐아이템에 반영할 수 있을 것 같습니다.